feat: add task abstraction - #8
Merged
Merged
Conversation
wispl
force-pushed
the
task-abstraction
branch
from
September 8, 2026 19:39
fe04186 to
5adb38a
Compare
ncorrea210
reviewed
Sep 21, 2026
ncorrea210
left a comment
ncorrea210
left a comment
Contributor
There was a problem hiding this comment.
Looks fine for the most part. It is a bit confusing to me how initialization looks for these tasks though. Is initialization done at construction? Is it expected that things like sensors are already initialized when handed off to the task?
Collaborator
Author
|
These are created and used the same way as the sensors and flash. We construct them and then call an init function. Sensors and other devices are expected to initialized before being passed to tasks. You can think of tasks as an optional extension of sensors and other devices. |
ncorrea210
approved these changes
Sep 25, 2026
ncorrea210
left a comment
ncorrea210
left a comment
Contributor
There was a problem hiding this comment.
Assuming this has been tested, i approve it
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, need to clear a couple of design decisions first and do a bit of testing before this can be merged
Other than that, everything else is fairly standard.
TODO: we need something to unsubscribe from the Registry, assuming we are keeping that model.